cmd-init: use sudo when creating src/config.json #3505
+8
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/retest |
When following the steps for building SCOS I ran `cosa init --variant scos https://github.com/openshift/os.git` and got a failure. Let's run this with `sudo` if we have the privileges to do so.
dustymabe
force-pushed
the
dusty-cmd-init
branch
from
dd8dc47
to
0334d4a
Compare
cgwalters
approved these changes
Jun 14, 2023
|
That's weird. We're doing all the repo cloning and directory setup with the same user. Wondering why we would need this here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When following the steps for building SCOS I ran
cosa init --variant scos https://github.com/openshift/os.gitand got a failure. Let's run this withsudo.