Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mantle: overhaul aliyun auth #3147

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dustymabe
Copy link
Member

The Aliyun SDK has a native file format it can consume for credentials [1]. This commit proposes we use that file format here and drop the custom JSON parsing that we're doing for Aliyun.

This commit also drops the toplevel --config argument in cmd-ore-wrapper because Aliyun was the only consumer of that argument.

[1] https://github.com/aliyun/alibaba-cloud-sdk-go/blob/710fea6cf27cf855f301462a2adcf3399169f63c/docs/2-Client-EN.md#2-credentials-file

@openshift-ci
Copy link

openshift-ci bot commented Oct 27, 2022

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@dustymabe
Copy link
Member Author

I'm not 100% sure we want to make this change, but I dug into the problem space today and figured I'd propose it if for nothing else than to reference the code in the future if we ever need it.

The Aliyun SDK has a native file format it can consume for
credentials [1]. This commit proposes we use that file format
here and drop the custom JSON parsing that we're doing for Aliyun.

This commit also drops the toplevel `--config` argument in
`cmd-ore-wrapper` because Aliyun was the only consumer of that argument.

[1] https://github.com/aliyun/alibaba-cloud-sdk-go/blob/710fea6cf27cf855f301462a2adcf3399169f63c/docs/2-Client-EN.md#2-credentials-file
@openshift-merge-robot
Copy link

@dustymabe: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants