mantle: overhaul aliyun auth #3147
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
|
I'm not 100% sure we want to make this change, but I dug into the problem space today and figured I'd propose it if for nothing else than to reference the code in the future if we ever need it. |
The Aliyun SDK has a native file format it can consume for credentials [1]. This commit proposes we use that file format here and drop the custom JSON parsing that we're doing for Aliyun. This commit also drops the toplevel `--config` argument in `cmd-ore-wrapper` because Aliyun was the only consumer of that argument. [1] https://github.com/aliyun/alibaba-cloud-sdk-go/blob/710fea6cf27cf855f301462a2adcf3399169f63c/docs/2-Client-EN.md#2-credentials-file
dustymabe
force-pushed
the
dusty-aliyun-credentials
branch
from
40ed170
to
1dd027b
Compare
|
@dustymabe: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Aliyun SDK has a native file format it can consume for credentials [1]. This commit proposes we use that file format here and drop the custom JSON parsing that we're doing for Aliyun.
This commit also drops the toplevel
--configargument incmd-ore-wrapperbecause Aliyun was the only consumer of that argument.[1] https://github.com/aliyun/alibaba-cloud-sdk-go/blob/710fea6cf27cf855f301462a2adcf3399169f63c/docs/2-Client-EN.md#2-credentials-file