add OnUpgrade callback #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe instead of adding a new callback, call existing OnShutdown callbacks during Upgrade? |
|
Just not sure if this will affect every plugin and giving unexpected behavior instead of just plugins that require closing socket |
|
yup, can't do, if i call shutdown before upgrade, it would change a lot of plugins behavior because normally OnShutdown called after new forked process is up, so it's better to call different event (OnUpgrade) instead (or maybe name this OnBeforeUpgrade?) |
Signed-off-by: Kiswono Prayogo <[email protected]>
kokizzu
force-pushed
the
onupgrade-callback
branch
from
81dc9f3
to
6fb0d95
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to this: coredns/coredns#6074
so all plugin that require releasing port can add themself to this callback.