Add more generics instructions #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gregcop1
reviewed
Feb 10, 2023
| - Enregistrez ce commit | ||
| - Créez une branche dédiée à votre fonctionnalité `feat/something-new` | ||
| - Réaliser l'une des modifications suivantes : | ||
| - Dans le fichier `index.html`: |
There was a problem hiding this comment.
Ça, ça ne marche plus s'ils se sont basé sur un dépôt local plutôt que cloner le projet. Est-ce qu'il ne faudrait pas carrément supprimer le côté HTML dans ce cas, ça serait sans doute moins confusant ?
| - Ajoutez de nouvelle modification au sein des premières lignes du fichier. | ||
| - Commitez ce changement toujours **sans la balise `section`** ou **sans le chien**. | ||
| - Mince ! Vous vous rendez-compte que ce changement n'aurait pas dû apparaître dans cette branche. Supprimez le commit. | ||
| - Créez une branche dédiée au fix `fix/my-correction` (c'est une correction de main, donc attention à la source de la branche utilisée) et appliquez-lui le commit que vous venez de supprimer. |
There was a problem hiding this comment.
J'imagine que tu y as pensé, mais il me semble qu'il faut modifier les slides pour correspondre à ces noms de branch quand ça sera mergé.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a non FrontEnd / non web public.