Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Authentik Oauth #4545

Merged
merged 14 commits into from
Dec 12, 2024
Merged

Feat: Authentik Oauth #4545

merged 14 commits into from
Dec 12, 2024

Conversation

peaklabs-dev
Copy link
Member

@peaklabs-dev peaklabs-dev commented Dec 11, 2024 •
edited by andrasbacsai
Loading

Needs attention

  • How do we ensure that the seeder will run again on existing installs?
  • Also I am not 100% certain that the new seeder is fully backwards compatible.

From @andrasbacsai: I fixed the seeder.

  • If there is a oauth with id 0, it migrates (with all its existing data) them to have valid id.
  • If some of the providers are missing, they will be created.
  • If no providers exists ( new Coolify installation ) then it create everything with the correct ids.

Changes

  • Feat: Authentik OAuth
  • fix: Oauth seeder no longer hardcodes IDs, as this is bad practice, and the oauth seeder can now be run multiple times.

Note: most of the work was done by this PR: #3840 I just fixed a few things.

danilomartinelli and others added 8 commits October 13, 2024 10:28
@danilomartinelli
feat: 🛂 integrate Authentik authentication with Coolify
96ef0ef 
- Configured Authentik as the OAuth provider in Coolify.
@peaklabs-dev
Merge branch 'next' into feature/authentik-provider
d9aefae
@peaklabs-dev
Merge pull request #3840 from danilomartinelli/feature/authentik-prov…
c2748de 
…ider

feature: Integrate Authentik Authentication with Coolify
@peaklabs-dev
fix: provider error
97b6257
@peaklabs-dev
Update composer.lock
edb14f8
@peaklabs-dev
chore: bump dep
46e6c9d
@peaklabs-dev
fix: database migration
aeb9740
@peaklabs-dev
fix: seeder
737f703 
- do not hardcode IDs as this is bad practice.
- Use update or create to allow the seeder to be run multiple times.
@peaklabs-dev peaklabs-dev marked this pull request as ready for review December 11, 2024 16:52
@peaklabs-dev peaklabs-dev changed the title Feat: Authentik Feat: Authentik Oauth Dec 11, 2024
@andrasbacsai
Copy link
Member

Thank you for the PR!

@andrasbacsai andrasbacsai merged commit dca30c2 into next Dec 12, 2024
4 checks passed
@peaklabs-dev peaklabs-dev deleted the authentik branch December 12, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@peaklabs-dev @andrasbacsai @danilomartinelli