-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add XDebug config to support php debugging. #3818
Conversation
# Conflicts: # config/sentry.php # config/version.php # versions.json
[xdebug] | ||
zend_extension=xdebug.so | ||
xdebug.mode=debug | ||
xdebug.start_with_request=yes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Never do this. Allow the triggers to function as they should.
docker/dev/xdebug.ini
Outdated
xdebug.mode=debug | ||
xdebug.start_with_request=yes | ||
xdebug.client_host=host.docker.internal | ||
xdebug.client_port=9000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Absolutely no reason to override the default. Since Xdebug 3, the default is 9003, for good reason (because 9000 conflicts with FPM and many other services).
docker/dev/xdebug.ini
Outdated
@@ -0,0 +1,7 @@ | |||
[xdebug] | |||
zend_extension=xdebug.so | |||
xdebug.mode=debug |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good start, but is also naive since it only supports debugging and not tracing or development helpers. I suggest this should be set to develop,debug
for now, and develop,debug,trace
once sane trace defaults are configured.
Co-authored-by: Bilge <[email protected]>
We recently upgraded to PHP8.4 and changed our Dockerfile a lot, can you please ajust this PR with new changes. If you do not have time to do this, please let me know so I can close this PR. |
Sorry for taking too long. Using XDebug is something new for me and I didn't know what capabilities there are and I currently don't have too much time figuring it all out. |
Changes