Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add XDebug config to support php debugging. #3818

Closed
wants to merge 7 commits into from

Conversation

MarioCakeDev
Copy link
Contributor

Changes

  • Added XDebug configuration to support remote debugging of php code

[xdebug]
zend_extension=xdebug.so
xdebug.mode=debug
xdebug.start_with_request=yes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never do this. Allow the triggers to function as they should.

xdebug.mode=debug
xdebug.start_with_request=yes
xdebug.client_host=host.docker.internal
xdebug.client_port=9000
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely no reason to override the default. Since Xdebug 3, the default is 9003, for good reason (because 9000 conflicts with FPM and many other services).

@@ -0,0 +1,7 @@
[xdebug]
zend_extension=xdebug.so
xdebug.mode=debug
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good start, but is also naive since it only supports debugging and not tracing or development helpers. I suggest this should be set to develop,debug for now, and develop,debug,trace once sane trace defaults are configured.

docker/dev/xdebug.ini Outdated Show resolved Hide resolved
@peaklabs-dev
Copy link
Member

We recently upgraded to PHP8.4 and changed our Dockerfile a lot, can you please ajust this PR with new changes. If you do not have time to do this, please let me know so I can close this PR.

@peaklabs-dev peaklabs-dev added the 💤 Waiting for changes PRs awaiting changes from the author. label Dec 16, 2024
@MarioCakeDev
Copy link
Contributor Author

Sorry for taking too long. Using XDebug is something new for me and I didn't know what capabilities there are and I currently don't have too much time figuring it all out.
Thanks for your patience. The PR can be closed. I will open up a new one if I really have more time for that. Or maybe someone else will have it done by then.

@github-actions github-actions bot removed the 💤 Waiting for changes PRs awaiting changes from the author. label Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants