-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Trigger.dev #3717
Fix: Trigger.dev #3717
Conversation
This will likely not run in Staging or Production because you're missing both the There are more complete versions (though still not following the deployment best practices provided by Trigger.dev) available in the discussion on this topic. You can find details of official deployment which myself and other have based our working examples off at: https://github.com/triggerdotdev/docker You can find the discussion at: #2439 |
@Mortalife Let me take a look at it closer and I'll join that discussion afterwards. |
I think this is still WIP, right? As we need the coorditor (and probably other stuffs) as well. |
@andrasbacsai Looking at it in the next hours. |
Not sure if I am the only one that has issues with shared configurations. They seem to not be working properly? I end up in the |
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
14127286 | Triggered | Generic Password | cda2e26 | lang/ro.json | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Hi... when release this version ?? |
@rennokki I have tested it and have one improvement request. Could you please check the healthcheck for Trigger as I am unsure if it has one and the current one is not working. |
Thank you for the PR 💜. I will test it and fix it if necessary. |
Changes
Fixed the Trigger.dev images pointing to the
latest
instead ofmain
.latest
tag is 8 months old and points to v2 whilemain
is the newest, v3.This will also fix problems with ARM machines not being able to run because
latest
isv2
and has no support forlinux/arm64
Trigger also comes with new services: Redis and Electric, which are configured in their own Docker examples.
Issues
N/A