Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service/influxdb #3710

Closed
wants to merge 7 commits into from
Closed

Conversation

mariusz-kraj
Copy link

Changes

  • New service template for InfluxDB

@peaklabs-dev
Copy link
Member

@mariusz-kraj This is a service right so it is comparable to WordPress for example ofc for Database Management but it is not a Database like Redis or Postgres right?

@peaklabs-dev peaklabs-dev added ⚙️ Service Issues requesting or PRs adding/fixing service templates. 💤 Waiting for feedback Issues awaiting a response from the author. labels Oct 10, 2024
@mariusz-kraj
Copy link
Author

Hi, this is a database. Optimized for time-series data and used extensively in IoT projects where you need to store sensor data over time.

It's also great for energy-related projects because it's very easy to make calculate power/energy calculations.

@peaklabs-dev
Copy link
Member

Thanks for the PR, this needs to be added to the codebase differently as a DB (I will leave this open for now).

@peaklabs-dev peaklabs-dev added ⚙️ Database A label for PRs that add a new database. and removed 💤 Waiting for feedback Issues awaiting a response from the author. ⚙️ Service Issues requesting or PRs adding/fixing service templates. labels Oct 10, 2024
@mariusz-kraj
Copy link
Author

I'm happy to help. Is there any documentation on how to add a new database?

@peaklabs-dev
Copy link
Member

No, there is no documentation, but you can check what files are needed by searching for an existing database such as keydb.

@peaklabs-dev
Copy link
Member

Thanks for the PR. Databases should not be added as service templates, they need to be added differently to the codebase. You can search for keydb for example to see how other DBs have been added. Could you please update your PR with these changes? If you do not have time to do it this way, I will close the PR for now.

@peaklabs-dev peaklabs-dev marked this pull request as draft October 14, 2024 12:57
@peaklabs-dev peaklabs-dev added the 💤 Waiting for feedback Issues awaiting a response from the author. label Oct 14, 2024
@mariusz-kraj
Copy link
Author

I will have some time over the weekend. I'll do my best to update the PR

@peaklabs-dev
Copy link
Member

Thank you for your contribution. Due to inactivity, we're closing this PR. If you'd like to revisit this change, feel free to reopen this PR or open a new pull request. I have also added a Discussion to track this #4038

@github-actions github-actions bot removed 💤 Waiting for feedback Issues awaiting a response from the author. ⚙️ Database A label for PRs that add a new database. labels Oct 28, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants