Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bad date NPE #143

Merged
merged 11 commits into from
Jan 4, 2019
Merged

Fix bad date NPE #143

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
87faf8b
fix(load): skip bad (null) dates when validating services
landonreed Sep 26, 2018
d673e36
test: add test with bad calendar dates
landonreed Nov 8, 2018
b552fb2
Merge branch 'dev' into fix-bad-date-npe
landonreed Nov 8, 2018
cd2627e
test: fix class name misspelling
landonreed Nov 8, 2018
77d29c7
Merge branch 'dev' into fix-bad-date-npe
landonreed Nov 9, 2018
62eb74e
test(gtfs): improve SQL GTFS integration tests
landonreed Nov 9, 2018
a3623fb
test: fix bad method signature
landonreed Nov 12, 2018
c874bc2
test: handle null date on snapshot
landonreed Nov 12, 2018
67a5d56
test: refactor vague assertion into countValidationErrorsOfType
landonreed Jan 3, 2019
71b5536
Merge branch 'dev' into fix-bad-date-npe
landonreed Jan 3, 2019
0311a68
test(writer): fix failure message in assertion
landonreed Jan 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/main/java/com/conveyal/gtfs/validator/ServiceValidator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,8 @@ select durations.service_id, duration_seconds, days_active from (
LocalDate firstDate = LocalDate.MAX;
LocalDate lastDate = LocalDate.MIN;
for (LocalDate date : dateInfoForDate.keySet()) {
// If the date is invalid, skip.
if (date == null) continue;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is this error happening? Shouldn't the computeIfAbsent method for adding keys and values never yield a null key? It'd be very helpful to add a failing test case to illustrate what is causing the problem here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@evansiroky, there are now tests that load feeds with bad date values. When you run canLoadFeedWithBadDates, you'll see that it does encounter a null key.

if (date.isBefore(firstDate)) firstDate = date;
if (date.isAfter(lastDate)) lastDate = date;
}
Expand Down