Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(add all): Change dot for dash A on git add #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AdGARAY
Copy link
Contributor

@AdGARAY AdGARAY commented Oct 12, 2020

This change must prevent that someone create a new commit inside a
directory, the git add . only adds the current directory, git add -A
adds all the files in the repository

This change must prevent that someone create a new commit inside a
directory, the git add . only adds the current directory, git add -A
adds all the files in the repository
@damianopetrungaro
Copy link
Member

Sorry for the embarrassing-late review, did you have any issue with this?
If so I'll rather add a new flag rather than introducing a BC to the package, what do you think?

@AdGARAY
Copy link
Contributor Author

AdGARAY commented Dec 18, 2020

That sounds good, how could you name it?, the only thing that I say is that --all and -a we wait to stage all and if we run git add. only adds the directory so we spect to have all the files but only the actual dir is added

@damianopetrungaro
Copy link
Member

what do you think about --all-repo and -ar? 🤔

@AdGARAY
Copy link
Contributor Author

AdGARAY commented Dec 18, 2020

That looks good 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants