feat:(lang): enable to add translating about page #432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cocoeyes02
changed the title
cocoeyes02
added a commit
to cocoeyes02/conventionalcommits.org
that referenced
this pull request
Apr 2, 2022
This was referenced Apr 2, 2022
|
I am not 100% sure we want to support tranlated "about" page as well since it mostly lists github projects. @bco]what do you think? |
|
@damianopetrungaro if it would help our international users, I have no concerns with translating the about page, as long as all existing translations would fall back to english unless added? When people submit new translations we should just make sure that we consider that page optional? I think the normative spec is the most important part to translate? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanna add japanese about page.
So I enable us to add translating about page in this PR.
How to: