Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pull-request number as an optional action input #142

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jprinet
Copy link

@jprinet jprinet commented Sep 29, 2023

This change allows to use the action with non pull_request / pull_request_target event trigger (ie. workflow_run)

fixes #141

@jprinet
Copy link
Author

jprinet commented Sep 29, 2023

Note: I don't see a conflict in the dist/index.js file, this one should probably be created by your CI anyway.

@ibakshay
Copy link
Member

ibakshay commented May 6, 2024

Hi @jprinet,
I apologize for the late response.

Thank you very much for your valuable contribution! I really appreciate it.
I am getting the below error when I do npm run build from this branch.
Could you please check?

ncc: Version 0.21.1
ncc: Compiling file index.js
Error: error:0308010C:digital envelope routines::unsupported
    at new Hash (node:internal/crypto/hash:68:19)
    at Object.createHash (node:crypto:138:10)
    at hashOf (evalmachine.<anonymous>:1:1411831)
    at module.exports (evalmachine.<anonymous>:1:1413919)
    at runCmd (evalmachine.<anonymous>:1:46102)
    at 819 (evalmachine.<anonymous>:1:43078)
    at __webpack_require__ (evalmachine.<anonymous>:1:216)
    at startup (evalmachine.<anonymous>:1:353)
    at module.exports.8 (evalmachine.<anonymous>:1:385)
    at evalmachine.<anonymous>:1:395 {
  opensslErrorStack: [ 'error:03000086:digital envelope routines::initialization error' ],
  library: 'digital envelope routines',
  reason: 'unsupported',
  code: 'ERR_OSSL_EVP_UNSUPPORTED'
}

@jprinet
Copy link
Author

jprinet commented May 15, 2024

Hi @ibakshay
No problem, I am getting a successful local run with a more recent ncc version
Would it be ok to upgrade?

➜  github-action git:(master) ✗ node --version                                                              
v16.20.1
➜  github-action git:(master) ✗ npm -version                                                                
8.19.4
➜  github-action git:(master) ✗ ncc --version
0.38.0
➜  github-action git:(master) ✗ npm run build                                                 

> [email protected] build
> tsc && ncc build

ncc: Version 0.38.0
ncc: Compiling file index.js into CJS
1151kB  dist/index.js
1151kB  [588ms] - ncc 0.38.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Support non pull_request event trigger
2 participants