-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 🎸 auto position combined link actions dropdown #453
Conversation
@DanweDE I'd hold off on this - there's a PR open to refactor the dropdown component to use a more stable positioning package (popper.js) - contentful/forma-36#597 |
@m10l this PR shouldn't conflict with that work, Seems like that PR is removing the |
The new combined reference link action's dropdown will be positioned automatically, if necessary, above the trigger button. This should prevent the menu from being cut off when e.g. positioned at the end of a page.
fee2327
to
6df21bf
Compare
Since the
|
@DanweDE Looks right, but the values passed to the dropdown are also the default values, so are you sure this commit changes anything? |
@denkristoffer Pretty sure this is necessary, see this line where the default is |
@denkristoffer @DanweDE should it be closed by #466? |
@suevalov No it looks like the "Create entry" dropdown disables automatic positioning by default, so this is a good change. |
The new combined reference link action's dropdown will be positioned automatically, if necessary, above the trigger button (in most cases, if there's enough space, it will still be shown below). This should prevent the menu from being cut off when e.g. positioned at the end of a page.