feat: testing branch for ESM-only packages [] #1526
Conversation
|
|
||
| const baseConfig = require('../../baseJestConfig'); | ||
| const packageJSON = require('./package.json'); | ||
| const packageName = packageJSON.name.split('@contentful/')[1]; |
There was a problem hiding this comment.
NIT: depending on your preference
| const packageName = packageJSON.name.split('@contentful/')[1]; | |
| const packageName = packageJSON.name.replace('@contentful/', ''); |
| "types": "dist/types/index.d.ts", | ||
| "exports": { |
There was a problem hiding this comment.
Do we need them or not?
I saw some post where it was mentioned that it was required for pure esm
other post are not mentioning them
There was a problem hiding this comment.
@andipaetzold going to tag you on this comment if that's okay? I don't think we need it, I've tested this in the web app and it works, but have also seen some articles recommending to have it in
| @@ -4,10 +4,10 @@ import { json } from '@codemirror/lang-json'; | |||
| import { indentUnit } from '@codemirror/language'; | |||
| import { EditorView } from '@codemirror/view'; | |||
| import tokens from '@contentful/f36-tokens'; | |||
| import CodeMirror from '@uiw/react-codemirror'; | |||
| import CodeMirror from '@uiw/react-codemirror/esm/index.js'; | |||
There was a problem hiding this comment.
❓ why do we need to import from esm
Shouldn't be automatically detected?
YvesRijckaert
force-pushed
the
feat/esm-only-json
branch
from
67fa702 to
1e6cdb6
Compare
| "main": "dist/cjs/index.js", | ||
| "module": "dist/esm/index.js", | ||
| "type": "module", | ||
| "main": "dist/esm/index.js", |
There was a problem hiding this comment.
This package stores the files in dist/esm while boolean stores them in dist directly. Can we align the setups?
There was a problem hiding this comment.
makes sense will do!
aodhagan-cf
changed the title
|
Marking pull request as stale since there was no activity for 30 days |
github-actions
bot
added
the
stale
Strategy