-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
spike: default field editors and json editor esm only [] #1510
Draft
aodhagan-cf
wants to merge
16
commits into
master
Choose a base branch
from
spike/esm-only
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aodhagan-cf
commented
Oct 3, 2023
aodhagan-cf
commented
Oct 3, 2023
andipaetzold
reviewed
Oct 4, 2023
aodhagan-cf
commented
Oct 23, 2023
@@ -12,7 +12,8 @@ | |||
} | |||
}, | |||
"module": { | |||
"type": "es6" | |||
"type": "es6", | |||
"strict": false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure about this
aodhagan-cf
changed the title
chore: making default field editors and json editor esm only []
BREAKING CHANGE: making default field editors and json editor esm only []
Oct 26, 2023
aodhagan-cf
changed the title
BREAKING CHANGE: making default field editors and json editor esm only []
BREAKING CHANGE: default field editors and json editor esm only []
Oct 26, 2023
aodhagan-cf
changed the title
BREAKING CHANGE: default field editors and json editor esm only []
spike: default field editors and json editor esm only []
Oct 27, 2023
Marking pull request as stale since there was no activity for 30 days |
github-actions
bot
added
the
stale
Used to mark when there was no activity for a set period of time
label
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
package:default-field-editors
package:json
package:_shared
package:_test
stale
Used to mark when there was no activity for a set period of time
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrating Default field editors and the json editor to ESM-only