Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade contentful-import, add ability to skip entries #2684

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

umazalakain
Copy link

Upgrades contentful-import and uses its ability to skip entries.

@umazalakain umazalakain requested a review from a team as a code owner July 11, 2024 13:36
})
.option('skip-content-updates', {
describe:
'Skips content updates. Skips updating existing content, only new content are created. Useful for incremental imports',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'Skips content updates. Skips updating existing content, only new content are created. Useful for incremental imports',
'Skips content updates. Skips updating existing content, only new content is created. Useful for incremental imports',

@jjolton-contentful
Copy link
Contributor

jjolton-contentful commented Jul 11, 2024

thanks again for the contribution @umazalakain, so exciting to see this come together!!! it would be really awesome to include some tests with this change now that the new functionality is available. The existing tests ("should print help message" and "should exit 1 when no args" in test/integration/cmds/space/import.test.js) also require a tweak to accompany these changes

Copy link
Contributor

@jjolton-contentful jjolton-contentful left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for the contribution @umazalakain, really so exciting to see all the pieces of this come together!!! It would be really awesome to include some tests with this change now that the new functionality is available. The existing tests ("should print help message" and "should exit 1 when no args" in test/integration/cmds/space/import.test.js) also require a tweak to accompany these changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants