feat: add option for default modifier for v10 types #345
Conversation
johannessjoberg
force-pushed
the
add-default-modifier-option
branch
from
178ef78 to
dbd9ddd
Compare
|
@marcolink What are your thoughts on these changes? |
|
Bump |
|
@marcolink Would love to see this get merged as it doesn't make sense to repeat this for every usage of the generated types. @johannessjoberg Should |
| @@ -31,6 +31,7 @@ class ContentfulMdg extends Command { | |||
| jsdoc: Flags.boolean({ char: 'd', description: 'add JSDoc comments' }), | |||
| typeguard: Flags.boolean({ char: 'g', description: 'add type guards' }), | |||
| response: Flags.boolean({ char: 'r', description: 'add response types' }), | |||
| modifier: Flags.string({ char: 'm', description: 'add default modifier (v10 only)' }), | |||
There was a problem hiding this comment.
Should we:
- allow all possible modifiers
- allow an array of modifiers to also support combinations?
|
Thanks for feedback @marcolink ! I'm not with Milkywire now and not actively using this package. Ping @andreaspalsson @hannasctyden @ekling to take over from here :) |
|
TL;DR I have a branch with my suggested way forward that I will push if there is no action on this PR in the next days! |
@marcolink Please feel free to push it. I don't think we will have the bandwidth to update this with support for more modifiers in the coming weeks. |
If you create your contentful client with an option like
contentful.createClient({ ... }).withoutUnresolvableLinksand reuse it everywhere, it would improve DX to be able to useTypeTestdirectly instead of explicitly statingTypeTest<'WITHOUT_UNRESOLVABLE_LINKS'>or usingTypeTestWithoutUnresolvableLinksResponse.This PR adds a default modifier option to achieve that.