Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Checking for multiple registries when login/logout #24888

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Checking for multiple registries when login/logout #24888

wants to merge 1 commit into from

Conversation

lslavkov
Copy link

Creating a check for podman login if there is a multiple registries in the registry.conf to avoid any issues where credential getting replaced by docker login

Fixes #22400

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 21, 2024

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added the do-not-merge/release-note-label-needed Enforce release-note requirement, even if just None label Dec 21, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 21, 2024
@packit-as-a-service Packit-as-a-Service
Copy link

Ephemeral COPR build failed. @containers/packit-build please check.

@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 21, 2024
@rhatdan
Copy link
Member

rhatdan commented Dec 23, 2024

Please rebase and squash your commit.

Thanks for the PR.

@rhatdan
Copy link
Member

rhatdan commented Dec 23, 2024

/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lslavkov, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 23, 2024
@lslavkov
add: checking multiple registries in config file
406024e 
Signed-off-by: Lazar Slavković-Raco <[email protected]>

# Conflicts:
#	cmd/podman/login.go
#	cmd/podman/logout.go
@lslavkov
Copy link
Author

@rhatdan I was able to squash it but my commit description got messed up. Hope that is nothing groundbreaking issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/release-note-label-needed Enforce release-note requirement, even if just None
Projects
None yet
Milestone
No milestone
3 participants
@lslavkov @rhatdan @openshift-merge-robot