Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[skip-ci] RPM: no qemu on RHEL #24748

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

lsm5
Copy link
Member

@lsm5 lsm5 commented Dec 3, 2024

This commit adjusts qemu dependency to be Fedora only.

Does this PR introduce a user-facing change?

None

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none labels Dec 3, 2024
Copy link
Contributor

openshift-ci bot commented Dec 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lsm5

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 3, 2024
@lsm5 lsm5 changed the title [skip-ci] [IGNORE] RPM: disable podman-machine on CentOS Stream [skip-ci] RPM: no qemu on RHEL Dec 6, 2024
@lsm5 lsm5 marked this pull request as ready for review December 6, 2024 12:23
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 6, 2024
@lsm5
Copy link
Member Author

lsm5 commented Dec 6, 2024

@Luap99 @jnovy @containers/podman-maintainers PTAL

@jnovy
Copy link
Contributor

jnovy commented Dec 6, 2024

LGTM, thanks

@lsm5 lsm5 force-pushed the no-qemu-centos branch 2 times, most recently from 2f614df to f06e369 Compare December 13, 2024 14:27
We only need qemu-system-[x86|aarch64]-core based on the architecture
along with qemu-img. So, there's no need to pull in all of qemu.

The qemu-system-[x86|aarch64]-core packages are not present on CentOS
Stream and RHEL, so we use qemu-kvm there instead.

Ref: https://github.com/containers/podman/pull/24369/files#r1883658262

Signed-off-by: Lokesh Mandvekar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants