Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(quadlet): parse comment lines with kv-pairs #24719

Closed
wants to merge 1 commit into from

fix(quadlet): parse comment lines with kv-pairs

f632a11
Select commit
Loading
Failed to load commit list.
Closed

fix(quadlet): parse comment lines with kv-pairs #24719

fix(quadlet): parse comment lines with kv-pairs
f632a11
Select commit
Loading
Failed to load commit list.
Cirrus CI / Validate fedora-39 Build failed Nov 30, 2024 in 6m 21s

Task Summary

Instruction main failed in 03:55

Details

✅ 00:33 clone
✅ 01:49 setup
❌ 03:55 main

golangci/golangci-lint info checking GitHub for tag 'v1.55.2'
golangci/golangci-lint info found version: 1.55.2 for v1.55.2/linux/amd64
golangci/golangci-lint info installed ./bin/golangci-lint
hack/golangci-lint.sh run

Running golangci-lint for tunnel
Build Tags tunnel: apparmor,seccomp,selinux,remote
Skipped directories tunnel: pkg/api,pkg/domain/infra/abi

Running golangci-lint for abi
Build Tags abi: apparmor,seccomp,selinux,systemd
Skipped directories abi:
Linting vs commit '70e4d02dbd57bf7980a33e722d868dc1c6bcbb72'
/root/.local/bin/pre-commit run -a
[INFO] Initializing environment for https://github.com/pre-commit/pre-commit-hooks.git.
[WARNING] repo `https://github.com/pre-commit/pre-commit-hooks.git` uses deprecated stage names (commit, push) which will be removed in a future version.  Hint: often `pre-commit autoupdate --repo https://github.com/pre-commit/pre-commit-hooks.git` will fix this.  if it does not -- consider reporting an issue to that repo.
[INFO] Installing environment for https://github.com/pre-commit/pre-commit-hooks.git.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
Fix End of Files.........................................................Passed
Trim Trailing Whitespace.................................................Passed
Mixed line ending........................................................Passed
check BOM - deprecated: use fix-byte-order-marker........................Passed
Check that executables have shebangs.....................................Passed
Check for merge conflicts................................................Passed
Check Yaml...............................................................Passed
Validating vs commit '70e4d02dbd57bf7980a33e722d868dc1c6bcbb72'
GIT_CHECK_EXCLUDE="./vendor:./test/tools/vendor:docs/make.bat:test/buildah-bud/buildah-tests.diff:test/e2e/quadlet/remap-keep-id2.container" ./test/tools/build/git-validation -run short-subject -range 70e4d02dbd57bf7980a33e722d868dc1c6bcbb72..HEAD
time="2024-11-30T10:51:57-06:00" level=info msg="using commit range: 70e4d02dbd57bf7980a33e722d868dc1c6bcbb72..HEAD"
 * f632a118d "fix(quadlet): parse comment lines with kv-pairs" ... PASS
# Check if the files can be loaded by the shell
. completions/bash/podman
if [ -x /bin/zsh ]; then /bin/zsh completions/zsh/_podman; fi
if [ -x /bin/fish ]; then /bin/fish completions/fish/podman.fish; fi
hack/man-page-checker
hack/xref-helpmsgs-manpages
xref-helpmsgs-manpages: 'podman inspect': --format options are available through autocomplete, but are not documented in docs/source/markdown/podman-inspect.1.md
hack/man-page-table-check
hack/swagger-check
contrib/cirrus/pr-should-include-tests
pr-should-include-tests: PR does not include changes in the 'tests' directory

Please write a regression test for what you're fixing. Even if it
seems trivial or obvious, try to add a test that will prevent
regressions.

If your change is minor, feel free to piggyback on already-written
tests, possibly just adding a small step to a similar existing test.
Every second counts in CI.

If your commit really, truly does not need tests, you can proceed
by adding '[NO NEW TESTS NEEDED]' to the body of your commit message.
Please think carefully before doing so.
make: *** [Makefile:700: tests-included] Error 1

Exit status: 2