Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency containers/automation_images to v20240513 - autoclosed #5526

Closed
wants to merge 1 commit into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented May 13, 2024

Mend Renovate

This PR contains the following updates:

Package Update Change
containers/automation_images major 20240411t124913z-f39f38d13 -> 20240513t140131z-f40f39d13

Release Notes

containers/automation_images (containers/automation_images)

v20240513t140131z-f40f39d13

Compare Source


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Never, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate renovate bot added the dependencies Pull requests that update a dependency file label May 13, 2024
@renovate renovate bot requested a review from cevich May 13, 2024 19:40
Copy link
Contributor

openshift-ci bot commented May 13, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: renovate[bot]
Once this PR has been reviewed and has the lgtm label, please assign ashley-cui for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

Ephemeral COPR build failed. @containers/packit-build please check.

@edsantiago
Copy link
Collaborator

I'm having a very hard time grokking those test logs, but this:

creating read-only layer with ID \"897856b864da34858af854187ea37dd01eafe09e988691597cad51eb8673bf49\": no space left on device", err:(*fmt.wrapError)(0xc0002ea460)}

...makes me suspect that we can't use tmpfs-/tmp on buildah: too diskhoggy. I've run into the same problem with 1minutetip. Only solution I can think of is to hardcode TMPDIR=/var/tmp. Any other ideas?

@edsantiago
Copy link
Collaborator

Plug for my podman-ginkgo-highlight GreaseMonkey script, which colorizes the PASS/FAIL lines. Still very human-unfriendly, but better.

@Luap99
Copy link
Member

Luap99 commented May 16, 2024

I'm having a very hard time grokking those test logs, but this:

creating read-only layer with ID \"897856b864da34858af854187ea37dd01eafe09e988691597cad51eb8673bf49\": no space left on device", err:(*fmt.wrapError)(0xc0002ea460)}

...makes me suspect that we can't use tmpfs-/tmp on buildah: too diskhoggy. I've run into the same problem with 1minutetip. Only solution I can think of is to hardcode TMPDIR=/var/tmp. Any other ideas?

Didn't we already run on tmpfs (on fedora) before my changes? AFAICT you tested the tmpfs thing with #5470?
If anything my tmpfs change should made the tmpfs bigger so I do not see why it would run of of space suddenly.

@edsantiago
Copy link
Collaborator

Didn't we already run on tmpfs (on fedora) before my changes?

Conformance tests run on Debian.

Looking more closely, I see:

  • TestConformance/copy_with_--chown -- fails only on vfs, with ENOSPC
  • TestConformance/ci-pipeline-modified -- fails on both vfs and overlay, with a real-looking error

As it turns out, there's some really weird clunky code that downloads docker-* packages in the VMs, but only installs them in buildah CI, so my get-versions script can't compare. This is the difference I found, manually, between the VM builds:

-5:26.0.0-1~debian.12~bookworm
+5:26.1.2-1~debian.12~bookworm    (basically, 26.0 to 26.1)

Conformance tests, IIRC, are very docker-dependent and break every time docker changes.

WHEW. After all that, I think the TL;DR is

  1. use TMPDIR=/var/tmp on debian
  2. fix conformance tests to deal with new docker

@Luap99
Copy link
Member

Luap99 commented May 16, 2024

Ah that is a mess, would be great to get the distro name into the task names. Because if there is none I am going to assume it uses fedora stable.

setting TMPDIR=/var/tmp sounds like a reasonable work around, actual test fixes for docker changes would likely be a @nalind task.

@edsantiago
Copy link
Collaborator

Agreed, actual fix needs @nalind attention. Here's (what I believe is) the relevant error output, to save on click-and-hunt time:

[+0571s]     conformance_test.go:484: 
                 	Error Trace:	/var/tmp/go/src/github.com/containers/buildah/tests/conformance/conformance_test.go:484
                 	            				/var/tmp/go/src/github.com/containers/buildah/tests/conformance/conformance_test.go:343
                 	            				/var/tmp/go/src/github.com/containers/buildah/tests/conformance/conformance_test.go:161
                 	Error:      	Image configurations differ as committed in Docker format
                 	Test:       	TestConformance/ci-pipeline-modified
                 	Messages:   	Fields which only exist in buildah version: parent
                 	            	Fields present in both versions have different values:
                 	            	Field                              Docker                                                       buildah
                 	            	config:WorkingDir                  /go/src/github.com/openshift/ocp-release-operator-sdk        /go/src/github.com/openshift/ocp-release-operator-sdk/
                 	            	container_config:WorkingDir        /go/src/github.com/openshift/ocp-release-operator-sdk        /go/src/github.com/openshift/ocp-release-operator-sdk/
             conformance_test.go:488: 
                 	Error Trace:	/var/tmp/go/src/github.com/containers/buildah/tests/conformance/conformance_test.go:488
                 	            				/var/tmp/go/src/github.com/containers/buildah/tests/conformance/conformance_test.go:343
                 	            				/var/tmp/go/src/github.com/containers/buildah/tests/conformance/conformance_test.go:161
                 	Error:      	Image configurations differ when converted to OCI format
                 	Test:       	TestConformance/ci-pipeline-modified
                 	Messages:   	Fields which only exist in buildah version: config:Labels
                 	            	Fields present in both versions have different values:
                 	            	Field                    Docker                                                       buildah
                 	            	config:WorkingDir        /go/src/github.com/openshift/ocp-release-operator-sdk        /go/src/github.com/openshift/ocp-release-operator-sdk/
[+0572s]     conformance_test.go:377: Dockerfile contents:
                 FROM busybox
                 WORKDIR /go/src/github.com/openshift/ocp-release-operator-sdk/
                 ENV GOPATH=/go
                 RUN env | grep -E -v '^(HOSTNAME|OLDPWD)=' | LANG=C sort | tee /env-contents.txt

@cevich
Copy link
Member

cevich commented May 21, 2024

I agree with Paul's suggestion it would be nice to have "Debian" in the task name. I can toss a quick PR to do this.

As it turns out, there's some really weird clunky code that downloads docker-* packages in the VMs, but only installs them in buildah CI

For some more context here, in case it helps:

IIRC the conformance tests use to run on Fedora and Ubuntu, until it became impossible/hard to install docker on Fedora. We also use to install the "latest" Docker at runtime, but this wrecked havoc with testing on release branches and flake all the time. CI VM build was updated to cache the packages for runtime install well before the switch to Debian. Much duct-tape has been piled on since then no doubt. Point is, these machinations are all very very old. I would not at all be opposed to improvements, so long as any changes are likely to survive long-term release-branch testing.

@@ -32,7 +32,7 @@ env:
DEBIAN_NAME: "debian-13"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also need to update:

    FEDORA_NAME: "fedora-40"
    PRIOR_FEDORA_NAME: "fedora-39"
    DEBIAN_NAME: "debian-13"

edsantiago added a commit to edsantiago/buildah that referenced this pull request May 29, 2024
Per consent in 2024-03-20 Planning, remove support for cgroups v1.
And, per discovery on 2024-05-28, systemd 256 no longer even
boots on a cgroups v1 system.

This commit switches to VMs built in:

  containers/automation_images#338

...in which Debian is now cgroups v2 with crun.

Requires disabling two conformance tests which fail when run
against docker 26.1; see containers#5526 for context on those.

And, latest git on f40 refuses to serve non-root files when
run as root ("dubious ownership"); so, in start_git_daemon(),
chown the extracted files.

Signed-off-by: Ed Santiago <[email protected]>
edsantiago added a commit to edsantiago/buildah that referenced this pull request May 29, 2024
Per consent in 2024-03-20 Planning, remove support for cgroups v1.
And, per discovery on 2024-05-28, systemd 256 no longer even
boots on a cgroups v1 system.

This commit switches to VMs built in:

  containers/automation_images#338

...in which Debian is now cgroups v2 with crun.

Requires disabling two conformance tests which fail when run
against docker 26.1; see containers#5526 for context on those.

Also requires disabling two bats tests on debian because
something changed there in ulimits. I'll look into them
later but right now this gives us breathing space.

And, latest git on f40 refuses to serve non-root files when
run as root ("dubious ownership"); so, in start_git_daemon(),
chown the extracted files.

Signed-off-by: Ed Santiago <[email protected]>
edsantiago added a commit to edsantiago/buildah that referenced this pull request May 29, 2024
Per consent in 2024-03-20 Planning, remove support for cgroups v1.
And, per discovery on 2024-05-28, systemd 256 no longer even
boots on a cgroups v1 system.

This commit switches to VMs built in:

  containers/automation_images#338

...in which Debian is now cgroups v2 with crun.

Requires disabling two conformance tests which fail when run
against docker 26.1; see containers#5526 for context on those.

Also requires disabling two bats tests on debian because
something changed there in ulimits. I'll look into them
later but right now this gives us breathing space.

And, latest git on f40 refuses to serve non-root files when
run as root ("dubious ownership"); so, in start_git_daemon(),
chown the extracted files.

Signed-off-by: Ed Santiago <[email protected]>
@renovate renovate bot changed the title chore(deps): update dependency containers/automation_images to v20240513 chore(deps): update dependency containers/automation_images to v20240513 - autoclosed Jun 3, 2024
@renovate renovate bot closed this Jun 3, 2024
@renovate renovate bot deleted the renovate/major-ci-vm-image branch June 3, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants