Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update project to latest shim-protos and ttrpc using protobuf 3.x #81

Merged
merged 1 commit into from
Jun 28, 2023

Conversation

jsturtevant
Copy link
Contributor

In preparation for adding windows #49 which is built using latest ttrpc libraries which use protobuf 3, this PR updates the project to use latest dependencies and moves the protocols to using protobuf 3.

note: There isn't a release of the shim-protos project with these changes yet so it pins a rev. I am going to open an issue on https://github.com/containerd/rust-extensions/ to see if we can get a release (or maybe wait till the windows changes propagate up). Opened this up to show required changes which allow for using Windows.

@jsturtevant
Copy link
Contributor Author

This is taking much longer than anticipated, things are moving along but slowly. I am finding it difficult to maintain this patch and work on the Windows implementation with the various changes going in for the youki work.

Any thoughts on pinning to a rev vs a realse so we can start bumping the other dependencies and moving forward on protobuf 3?

@devigned
Copy link
Contributor

This is taking much longer than anticipated, things are moving along but slowly. I am finding it difficult to maintain this patch and work on the Windows implementation with the various changes going in for the youki work.

Any thoughts on pinning to a rev vs a realse so we can start bumping the other dependencies and moving forward on protobuf 3?

I'm good with pinning to a rev as long as we have an issue to track the follow up work. What do others think?

Signed-off-by: James Sturtevant <[email protected]>
@jsturtevant jsturtevant marked this pull request as ready for review June 27, 2023 23:33
@jsturtevant
Copy link
Contributor Author

@jsturtevant
Copy link
Contributor Author

I'm good with pinning to a rev as long as we have an issue to track the follow up work. What do others think?

I've refreshed the PR and opened #162 to track updating getting this on a release

@cpuguy83 cpuguy83 merged commit 78d919f into containerd:main Jun 28, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants