Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Scripts for setup new dev environment #680

Merged
merged 4 commits into from
Oct 1, 2024

Conversation

fawadasaurus
Copy link
Contributor

I setup a new dev environment and wanted to get the project running on my OSX machine. I installed a fresh Linux VM and was able to run make build and make test with this setup.

I encountered one test failure. I don't believe this failure would only impact me as the oci_spec default for environment variables sets 2 environment variables. So I set the

impl Default for Process {
    fn default() -> Self {
        Process {
....
            // Sets linux default enviroment for binaries and default xterm emulator
            env: vec![
                "PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin".into(),
                "TERM=xterm".into(),
            ]

@Mossaka
Copy link
Member

Mossaka commented Sep 30, 2024

Thanks for fixing this bug! I just realized that our build pipeline is not set up correctly to fail when the make test- fails...

@fawadasaurus
Copy link
Contributor Author

Thanks for fixing this bug! I just realized that our build pipeline is not set up correctly to fail when the make test- fails...

I can try to address that as well in this PR if you would like.

@Mossaka
Copy link
Member

Mossaka commented Sep 30, 2024

that would be nice! I briefly looked into it with #682 , and suprisingly found that cross test returns status code 0 with a test failure.

@@ -1,6 +1,6 @@
#!/bin/bash
sudo apt -y update
sudo apt install -y pkg-config libsystemd-dev libdbus-glib-1-dev build-essential libelf-dev libseccomp-dev libclang-dev libzstd-dev protobuf-compiler
sudo apt install -y pkg-config libsystemd-dev libdbus-glib-1-dev build-essential libelf-dev libseccomp-dev libclang-dev libzstd-dev protobuf-compiler libssl-dev
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add libssl dep to cross/Dockerfile_* as well?

@Mossaka Mossaka merged commit 167d7cc into containerd:main Oct 1, 2024
52 checks passed
Mossaka added a commit to Mossaka/runwasi that referenced this pull request Oct 1, 2024
@fawadasaurus fawadasaurus deleted the fix_setup branch October 1, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants