Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wasmtime: tidy up #675

Merged
merged 8 commits into from
Sep 30, 2024
Merged

wasmtime: tidy up #675

merged 8 commits into from
Sep 30, 2024

Conversation

Mossaka
Copy link
Member

@Mossaka Mossaka commented Sep 20, 2024

small refactoring and formating over the wasmtime shim.

@Mossaka Mossaka marked this pull request as ready for review September 20, 2024 01:31
jprendes
jprendes previously approved these changes Sep 20, 2024
Copy link
Collaborator

@jprendes jprendes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Personally I prefer func over wasm_func_name, but if you find the latter cleaner, go ahead!

Do you know why CI failed?

@Mossaka
Copy link
Member Author

Mossaka commented Sep 24, 2024

LGTM.

Personally I prefer func over wasm_func_name, but if you find the latter cleaner, go ahead!

Do you know why CI failed?

probably related to the changes I made. Will take a look

Copy link
Collaborator

@jprendes jprendes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jprendes jprendes merged commit 399c4cc into containerd:main Sep 30, 2024
52 checks passed
@Mossaka Mossaka deleted the refactoring-wasmtime branch September 30, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants