Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add devbox as an install tool #3191

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

burritobill
Copy link

Adding devbox to this repo as asked in renovatebot/renovate#30002

renovate.json Outdated Show resolved Hide resolved
renovate.json Outdated Show resolved Hide resolved
renovate.json Outdated Show resolved Hide resolved
@burritobill
Copy link
Author

Happy to add some more tests if required, I wasn't sure if I was required to add a /test/devbox/* set of tests

@burritobill burritobill force-pushed the feat/add_devbox_install_tool branch 2 times, most recently from e2441ec to ac90daf Compare September 6, 2024 03:39
@burritobill
Copy link
Author

Would adding the Dockerfiles in /test/devbox/* fix the code coverage issue?

@burritobill
Copy link
Author

@viceice What do you want me to do to get this one in?

Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ignore the coverage issues or add vitest tests 🤗

src/cli/tools/devbox.ts Outdated Show resolved Hide resolved
src/cli/tools/devbox.ts Show resolved Hide resolved
@burritobill burritobill force-pushed the feat/add_devbox_install_tool branch 3 times, most recently from 57f2a96 to 03f6c9f Compare October 1, 2024 06:27
@viceice viceice disabled auto-merge October 11, 2024 09:31
@viceice
Copy link
Member

viceice commented Oct 11, 2024

Does devbox use any files or folders in user home dir?

@burritobill
Copy link
Author

burritobill commented Oct 13, 2024

Does devbox use any files or folders in user home dir?

devbox definitely uses stuff in the home dir (on macos at least)

the “devbox binary” is a shell script in /usr/local/bin/devbox that handles updating and the USE_DEVBOX_VERSION env var, and then executes the binary in ~/.cache/devbox/bin/
~/.cache/devbox has some other cache stuff for nixpkgs
~/.local/share/devbox/ contains the global process-compose.json (keeps track of all running processes) and the global devbox.json for when you devbox global add some_pkg
~/.local/state/devbox/ has what looks like cache data (but maybe only from old devbox versions?)

https://www.jetify.com/docs/devbox/faq/#how-can-i-uninstall-devbox
Shows some of the things required by devbox

@viceice
Copy link
Member

viceice commented Nov 6, 2024

Does devbox use any files or folders in user home dir?

devbox definitely uses stuff in the home dir (on macos at least)

the “devbox binary” is a shell script in /usr/local/bin/devbox that handles updating and the USE_DEVBOX_VERSION env var, and then executes the binary in ~/.cache/devbox/bin/ ~/.cache/devbox has some other cache stuff for nixpkgs ~/.local/share/devbox/ contains the global process-compose.json (keeps track of all running processes) and the global devbox.json for when you devbox global add some_pkg ~/.local/state/devbox/ has what looks like cache data (but maybe only from old devbox versions?)

https://www.jetify.com/docs/devbox/faq/#how-can-i-uninstall-devbox Shows some of the things required by devbox

Thanks, ~/.cache and ~/.local are already handled 🤗

Comment on lines +116 to +118
# renovate: datasource=github-releases packageName=jetify-com/devbox
RUN install-tool devbox 0.13.4

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sort alphabetical

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants