Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor tests #16

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Conversation

petrduda
Copy link

@petrduda petrduda commented Mar 10, 2023

  • stop calling static methods in tests as non-static
  • use assertSame() where assertEquals() is not explicitly needed
  • use assertCount() after assertContains() for array comparison
  • add missing Assert::fail() in try+catch blocks when expecting exceptions
  • unify Assert::fail() message
  • replace Consistence\TestCase::ok() with expectNotToPerformAssertions()
  • use try+catch+fail when expecting exceptions with properties
  • rename data providers to singular where applicable
  • use DataProvider suffix for data providers
  • change data provider return type from array to Generator
  • declare data provider values on separate lines
  • isolate data provider cases using Closures
  • name data provider values
  • name data provider cases
  • extract multiple cases from test methods to data providers
  • remove unnecessary private methods for creating mocks

@petrduda petrduda force-pushed the pd-refactor-tests branch 3 times, most recently from 30bf3d9 to ada7bc4 Compare March 13, 2023 10:51
tests/Generated/SentryAutoloaderTest.php Outdated Show resolved Hide resolved
tests/Factory/Simple/SimpleSentryFactoryTest.php Outdated Show resolved Hide resolved
tests/Metadata/PropertyMetadataTest.php Outdated Show resolved Hide resolved
tests/Type/AbstractSentryTest.php Outdated Show resolved Hide resolved
tests/Type/CollectionTest.php Outdated Show resolved Hide resolved
tests/Type/CollectionTest.php Outdated Show resolved Hide resolved
tests/Type/SimpleTypeTest.php Outdated Show resolved Hide resolved
tests/Type/SimpleTypeTest.php Outdated Show resolved Hide resolved
@petrduda petrduda force-pushed the pd-refactor-tests branch from ada7bc4 to 2eb246a Compare April 18, 2023 21:11
@petrduda petrduda force-pushed the pd-refactor-tests branch from 2eb246a to 1d33fe8 Compare April 23, 2023 13:47
@petrduda petrduda force-pushed the pd-refactor-tests branch from 1d33fe8 to d5359b3 Compare April 24, 2023 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants