DI and config refactoring #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
petrduda
commented
Nov 24, 2024
•
petrduda
commented
- rename Symfony yml files to yaml
- use multiline format for attributes in YAML
- quote all strings in YAML
- use FQN method style of factories
- pass arguments in DI by name
- do not use constants for DI parameters
- do not use fluent interface for Symfony configuration
petrduda
force-pushed
the
pd-di-and-config-refactoring
branch
from
f3603c2 to
18e1041
Compare
VasekPurchart
requested changes
Nov 26, 2024
petrduda
force-pushed
the
pd-di-and-config-refactoring
branch
from
18e1041 to
432d51d
Compare
Fixed. |
VasekPurchart
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.