Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow doctrine/doctrine-bundle 2.0 #13

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mhujer
Copy link

@mhujer mhujer commented Nov 20, 2019

Closes #12

@finwe
Copy link

finwe commented Nov 21, 2019

Could this also allow 5.0 versions of symfony/* packages? Or should I create a separate PR for that?

@mhujer
Copy link
Author

mhujer commented Nov 24, 2019

@VasekPurchart ping?

@VasekPurchart
Copy link
Member

Hi, you can create separate PR for that.

But I have not much interest in the type of PRs where only composer.json is changed. I will have to look at the changes in the libraries and test it anyways. So in the end the only valuable thing in these is that you tested it, which I appreciate.

@VasekPurchart
Copy link
Member

I hope I will have time to work on such issues on tuesday.

@mhujer
Copy link
Author

mhujer commented Nov 24, 2019

@VasekPurchart fair point!

It seems there are no changes affecting this library in the changelog.

I tested my branch in project with doctrine/orm 2.7 + doctrine/doctrine-bundle 2.0.0 + Symfony 4.4 and the hydratation of enums works fine and there are no deprecations related to this bundle.

@enumag
Copy link

enumag commented Dec 3, 2019

bump, can I help somehow?

@mhujer
Copy link
Author

mhujer commented Dec 3, 2019

@enumag For now I'm using this in composer.json:

    "repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/mhujer/consistence-doctrine-symfony"
        }
    ],
    "require": {
        "consistence/consistence-doctrine-symfony": "dev-newdeps"
    }

Diff https://github.com/consistence/consistence-doctrine-symfony/compare/master...mhujer:newdeps?expand=1

@enumag
Copy link

enumag commented Dec 3, 2019

@mhujer not exactly what I was asking for haha. I know how to use composer. But thanks for trying anyway.

@mhujer
Copy link
Author

mhujer commented Dec 4, 2019

@enumag I thought so ;-)

@enumag
Copy link

enumag commented Dec 12, 2019

ping @VasekPurchart I'd like to try to upgrade to SF 5 next week. This seems like the last dependency blocking my project

@enumag
Copy link

enumag commented Feb 20, 2020

@mhujer I'm trying your branch and would appreciate an advice. Previously I was using this:

services:
    consistence.doctrine.enum.enum_fields_cache:
        parent: doctrine_cache.abstract.apcu

With SF 5 the DoctrineCacheBundle is gone so there is no doctrine_cache.abstract.apcu service. How to configure it now? From what I can see, Doctrine is now configured to use symfony/cache wrapped by Symfony\Component\Cache\DoctrineProvider. I'm not quite sure how to write that though.

@mhujer
Copy link
Author

mhujer commented Mar 7, 2020

@enumag I have no idea, sorry. I haven't configured cache for the enums yet.

@mhujer
Copy link
Author

mhujer commented Mar 6, 2021

Hello,

I'm using Consistence libraries on several projects, so I decided to fork them and maintain them under consistence-community namespace.

The maintained consistence-doctrine-symfony library is here: https://github.com/consistence-community/consistence-doctrine-symfony

The consistence-community packages should be drop-in replacements while supporting newer PHP/Symfony versions. It should be enough to replace consistence/ with consistence-community/ in the composer.json (along with the version constraint) and run composer update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for doctrine/doctrine-bundle 2.0.0
4 participants