-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow doctrine/doctrine-bundle 2.0 #13
base: master
Are you sure you want to change the base?
Conversation
Could this also allow 5.0 versions of symfony/* packages? Or should I create a separate PR for that? |
@VasekPurchart ping? |
Hi, you can create separate PR for that. But I have not much interest in the type of PRs where only composer.json is changed. I will have to look at the changes in the libraries and test it anyways. So in the end the only valuable thing in these is that you tested it, which I appreciate. |
I hope I will have time to work on such issues on tuesday. |
@VasekPurchart fair point! It seems there are no changes affecting this library in the changelog. I tested my branch in project with doctrine/orm 2.7 + doctrine/doctrine-bundle 2.0.0 + Symfony 4.4 and the hydratation of enums works fine and there are no deprecations related to this bundle. |
bump, can I help somehow? |
@enumag For now I'm using this in "repositories": [
{
"type": "vcs",
"url": "https://github.com/mhujer/consistence-doctrine-symfony"
}
],
"require": {
"consistence/consistence-doctrine-symfony": "dev-newdeps"
} Diff https://github.com/consistence/consistence-doctrine-symfony/compare/master...mhujer:newdeps?expand=1 |
@mhujer not exactly what I was asking for haha. I know how to use composer. But thanks for trying anyway. |
@enumag I thought so ;-) |
ping @VasekPurchart I'd like to try to upgrade to SF 5 next week. This seems like the last dependency blocking my project |
@mhujer I'm trying your branch and would appreciate an advice. Previously I was using this:
With SF 5 the DoctrineCacheBundle is gone so there is no |
@enumag I have no idea, sorry. I haven't configured cache for the enums yet. |
Hello, I'm using Consistence libraries on several projects, so I decided to fork them and maintain them under The maintained The consistence-community packages should be drop-in replacements while supporting newer PHP/Symfony versions. It should be enough to replace |
Closes #12