Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor tests #79

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

petrduda
Copy link

@petrduda petrduda commented Mar 9, 2023

  • stop calling static methods in tests as non-static
  • use assertSame() where assertEquals() is not explicitly needed
  • use assertCount() after assertContains() for array comparison
  • add missing Assert::fail() in try+catch blocks when expecting exceptions
  • unify Assert::fail() message
  • replace Consistence\TestCase::ok() with expectNotToPerformAssertions()
  • use try+catch+fail when expecting exceptions with properties
  • rename data providers to singular where applicable
  • use DataProvider suffix for data providers
  • change data provider return type from array to Generator
  • declare data provider values on separate lines
  • isolate data provider cases using Closures
  • name data provider values
  • name data provider cases
  • extract multiple cases from test methods to data providers
  • remove unnecessary private methods for creating mocks

Copy link
Member

@VasekPurchart VasekPurchart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants