Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conver to ts #57

Open
wants to merge 35 commits into
base: master
Choose a base branch
from
Open

Conver to ts #57

wants to merge 35 commits into from

Conversation

bullocgr
Copy link
Contributor

@bullocgr bullocgr commented Aug 1, 2023

@bullocgr bullocgr requested a review from a team August 3, 2023 09:45
@chribsen chribsen self-assigned this Aug 7, 2023
chribsen
chribsen reviewed Aug 7, 2023
View reviewed changes
Dockerfile Show resolved Hide resolved
bin/jwtdecode.test.ts Outdated Show resolved Hide resolved
bin/jwtdecode.test.ts Outdated Show resolved Hide resolved
bin/jwtencode.test.ts Outdated Show resolved Hide resolved
bin/jwtencode.test.ts Outdated Show resolved Hide resolved
src/jwtserviceauth.ts Show resolved Hide resolved
src/processutils.ts Outdated
const stdOutMaxSize = options.stdOutMaxSize || maxSize
const stdErrMaxSize = options.stdErrMaxSize || maxSize

const promise = new Promise((resolve, reject) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const promise = new Promise((resolve, reject) => {
const promise = new Promise<ProcessResult>((resolve, reject) => {

If you do this, then the redundant piece in L66-L73 can be removed

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You committed my changes, but didn't remove the any in what is now L55

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and L67

src/processutils.ts Outdated Show resolved Hide resolved
src/processutils.ts Outdated Show resolved Hide resolved
src/pubkeyshelper.ts Outdated Show resolved Hide resolved
@chribsen
Copy link
Contributor

chribsen commented Aug 7, 2023

A general comment would be that it could be neat to change those Record<....> with some a well-defined interfaces like JWT and JWK

bullocgr and others added 4 commits August 15, 2023 13:10
@bullocgr @chribsen
Update bin/jwtdecode.test.ts
b50b685 
Co-authored-by: Christian Danielsen <[email protected]>
@bullocgr @chribsen
Update bin/jwtdecode.test.ts
56ff8e0 
Co-authored-by: Christian Danielsen <[email protected]>
@bullocgr @chribsen
Update bin/jwtencode.test.ts
88d7141 
Co-authored-by: Christian Danielsen <[email protected]>
@bullocgr @chribsen
Update bin/jwtencode.test.ts
122b67e 
Co-authored-by: Christian Danielsen <[email protected]>
@bullocgr @chribsen
Update src/jwtserviceautherror.ts
98de71e 
Co-authored-by: Christian Danielsen <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Aug 15, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability E 4 Vulnerabilities
Security Hotspot E 28 Security Hotspots
Code Smell A 35 Code Smells

No Coverage information No Coverage information
1.3% 1.3% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

bullocgr and others added 5 commits August 15, 2023 13:11
@bullocgr @chribsen
Update src/processutils.ts
e8ee055 
Co-authored-by: Christian Danielsen <[email protected]>
@bullocgr @chribsen
Update sample/googleoauth2v2/index.ts
db76944 
Co-authored-by: Christian Danielsen <[email protected]>
@bullocgr @chribsen
Update package.json
3bcbb06 
Co-authored-by: Christian Danielsen <[email protected]>
@bullocgr @chribsen
Update package.json
e4c3d46 
Co-authored-by: Christian Danielsen <[email protected]>
@bullocgr @chribsen
Update src/index.ts
bf11064 
Co-authored-by: Christian Danielsen <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Aug 15, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability E 4 Vulnerabilities
Security Hotspot E 28 Security Hotspots
Code Smell A 35 Code Smells

No Coverage information No Coverage information
1.2% 1.2% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

chribsen
chribsen requested changes Sep 11, 2023
View reviewed changes
Copy link
Contributor

@chribsen chribsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comments in regards to the old unresolved comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chribsen chribsen chribsen requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@chribsen chribsen

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bullocgr @chribsen