-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom log filtering #95
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…unnecessary heap allocations
…ges until actually accessed by consumer
endret
requested changes
Jul 30, 2024
4 tasks
endret
requested changes
Aug 1, 2024
endret
requested changes
Aug 1, 2024
adams85
force-pushed
the
feature/logfilter
branch
from
August 2, 2024 18:03
70c5c3f
to
c4e59ed
Compare
endret
approved these changes
Aug 2, 2024
|
||
public bool IsValueCreated => this.argsOrValue is null or string; | ||
|
||
public override string ToString() => Value ?? string.Empty; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<3
adams85
force-pushed
the
feature/logfilter
branch
from
August 21, 2024 07:17
648ff6a
to
e607ac4
Compare
Quality Gate failedFailed conditions See analysis details on SonarCloud Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the purpose of your pull request
Provides a new, more convenient way (
ConfigCatClientOptions.LogFilter
) for consumers to specify custom log event filter logic.Also, brings some performance improvements (reduced memory allocation) around log messages and evaluation log building:
ConfigCat.Client.Benchmarks.MatrixTestBenchmark
Related issues (only if applicable)
https://trello.com/c/IxCFbq2j
Requirement checklist (only if applicable)