Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluation log improvements #89

Merged
merged 9 commits into from
Mar 21, 2024
Merged

Evaluation log improvements #89

merged 9 commits into from
Mar 21, 2024

Conversation

adams85
Copy link
Contributor

@adams85 adams85 commented Feb 14, 2024

Describe the purpose of your pull request

Aligns evaluation logging and evaluator error reporting in some edge cases where the config json contains errors.

Also, fixes come inconsistencies with other SDKs.

Breaking changes:

  • Change the name of some UserComparator members: Is(Not)OneOf -> TextIs(Not)OneOf, SensitiveIs(Not)OneOf -> SensitiveTextIs(Not)OneOf, (Not)ContainsAnyOf ->Text(Not)ContainsAnyOf

Requirement checklist (only if applicable)

  • I have covered the applied changes with automated tests.
  • I have executed the full automated test set against my changes.
  • I have validated my changes against all supported platform versions.
  • I have read and accepted the contribution agreement.

@adams85 adams85 requested a review from a team as a code owner February 14, 2024 14:19
@adams85 adams85 force-pushed the eval-log-improvements branch from bbf2f98 to 1708c22 Compare February 14, 2024 14:41
Copy link

sonarcloud bot commented Mar 21, 2024

@adams85 adams85 merged commit ed0a54d into master Mar 21, 2024
7 checks passed
@adams85 adams85 deleted the eval-log-improvements branch March 21, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants