Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor improvements and fixes #87

Merged
merged 6 commits into from
Jan 9, 2024
Merged

Minor improvements and fixes #87

merged 6 commits into from
Jan 9, 2024

Conversation

adams85
Copy link
Contributor

@adams85 adams85 commented Jan 5, 2024 •
edited
Loading

Describe the purpose of your pull request

  • Don't swallow but log exceptions when config json deserialization fails so users can get a clue about what went wrong with the deserialization.
  • Minor fixes and code quality improvements.

Related issues (only if applicable)

https://trello.com/c/MgdAUtoA
https://trello.com/c/Mb7rvm64

Requirement checklist (only if applicable)

  • I have covered the applied changes with automated tests.
  • I have executed the full automated test set against my changes.
  • I have validated my changes against all supported platform versions.
  • I have read and accepted the contribution agreement.

@adams85 adams85 requested a review from a team as a code owner January 5, 2024 13:19
@adams85 adams85 force-pushed the minor-improvements-and-fixes-3 branch from ab4f37e to ce91193 Compare January 9, 2024 13:02
@adams85 adams85 force-pushed the minor-improvements-and-fixes-3 branch from 778b545 to a74878a Compare January 9, 2024 13:11
@adams85 adams85 merged commit 71f21c0 into master Jan 9, 2024
6 checks passed
@adams85 adams85 deleted the minor-improvements-and-fixes-3 branch January 9, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laliconfigcat laliconfigcat laliconfigcat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adams85 @laliconfigcat