-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Config v6 #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adams85
force-pushed
the
config-v6
branch
7 times, most recently
from
July 1, 2023 07:20
098326c
to
e3a71e3
Compare
adams85
force-pushed
the
config-v6
branch
2 times, most recently
from
July 3, 2023 15:58
4d58bbd
to
3c1e539
Compare
adams85
force-pushed
the
config-v6
branch
5 times, most recently
from
July 27, 2023 09:05
0de33ca
to
eefe660
Compare
adams85
force-pushed
the
config-v6
branch
11 times, most recently
from
August 3, 2023 15:11
ad0bd21
to
6f91bd4
Compare
adams85
force-pushed
the
config-v6
branch
2 times, most recently
from
October 27, 2023 18:27
c175c7d
to
3841ea0
Compare
laliconfigcat
approved these changes
Nov 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
endret
reviewed
Nov 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it would be nice to ensure some explicit unit tests for new utils functions.
endret
approved these changes
Nov 13, 2023
z4kn4fein
approved these changes
Nov 15, 2023
Kudos, SonarCloud Quality Gate passed! |
kp-cat
approved these changes
Nov 20, 2023
kp-cat
reviewed
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the purpose of your pull request
Implements config v6 support.
Features/improvements:
config_v6.json
) and update config modelEvaluationDetails.MatchedTargetingRule
/MatchedPercentageOption
properties (rename + set combinations correctly)Tests:
EvaluationDetails.MatchedTargetingRule
/MatchedPercentageOption
properties (rename + set combinations correctly)Related improvements/fixes:
We should go to the cache in all polling modes instead of using the in memory variable (see https://trello.com/c/rreKm64A)(done earlier)Breaking changes:
MatchedEvaluationRule
property toMatchedTargetingRule
and theMatchedEvaluationPercentageRule
property toMatchedPercentageOption
inEvaluationDetails
.IConfig
and related interfaces/enums).User.Custom
to disallow null values.User.AllAttributes
property into a method (GetAllAttributes
) as it allocates under the hood.Requirement checklist (only if applicable)