Consolidate percentage rule evaluation logs

configcat · Aug 5, 2022 · fda6f96 · fda6f96
1 parent aea93d4
commit fda6f96
Showing 1 changed file with 4 additions and 9 deletions.
diff --git a/src/ConfigCatClient/Evaluate/RolloutEvaluator.cs b/src/ConfigCatClient/Evaluate/RolloutEvaluator.cs
@@ -100,19 +100,13 @@ private EvaluateResult EvaluateLogic(IDictionary<string, Setting> settings, stri
 
                     // evaluate variations
 
-                    if (TryEvaluateVariations(setting.RolloutPercentageItems, key, user, out result))
+                    if (TryEvaluateVariations(setting.RolloutPercentageItems, key, user, evaluateLog, out result))
                     {
-                        evaluateLog.Log("Evaluate % option => user targeted");
                         evaluateLog.ReturnValue = result.Value.ToString();
                         evaluateLog.VariationId = result.VariationId;
-
                         result.SettingType = setting.SettingType;
                         return result;
                     }
-                    else
-                    {
-                        evaluateLog.Log("Evaluate % option => user not targeted");
-                    }
                 }
                 else if (setting.RolloutRules.Any() || setting.RolloutPercentageItems.Any())
                 {
@@ -139,7 +133,8 @@ private EvaluateResult EvaluateLogic(IDictionary<string, Setting> settings, stri
             }
         }
 
-        private static bool TryEvaluateVariations(ICollection<RolloutPercentageItem> rolloutPercentageItems, string key, User user, out EvaluateResult result)
+        private static bool TryEvaluateVariations<T>(ICollection<RolloutPercentageItem> rolloutPercentageItems, string key, User user, 
+            EvaluateLogger<T> evaluateLog, out EvaluateResult result)
         {
             result = new EvaluateResult();
 
@@ -160,7 +155,7 @@ private static bool TryEvaluateVariations(ICollection<RolloutPercentageItem> rol
                     if (hashScale >= bucket) continue;
                     result.Value = variation.Value;
                     result.VariationId = variation.VariationId;
-
+                    evaluateLog.Log($"Evaluating % options, '{key}' evaluated to '{variation.Value}'.");
                     return true;
                 }
             }