Minor corrections

configcat · Feb 8, 2024 · decab11 · decab11
1 parent a63cf49
commit decab11
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/src/ConfigCatClient/Evaluation/EvaluateLogHelper.cs b/src/ConfigCatClient/Evaluation/EvaluateLogHelper.cs
@@ -121,7 +121,7 @@ UserComparator.SensitiveTextEquals or
 
     public static IndentedTextBuilder AppendPrerequisiteFlagCondition(this IndentedTextBuilder builder, PrerequisiteFlagCondition condition)
     {
-        var prerequisiteFlagKey = condition.PrerequisiteFlagKey;
+        var prerequisiteFlagKey = condition.PrerequisiteFlagKey ?? InvalidReferencePlaceholder;
         var comparator = condition.Comparator;
         var comparisonValue = condition.ComparisonValue.GetValue(throwIfInvalid: false);
 

diff --git a/src/ConfigCatClient/Evaluation/RolloutEvaluator.cs b/src/ConfigCatClient/Evaluation/RolloutEvaluator.cs
@@ -298,7 +298,7 @@ private bool EvaluateConditions<TCondition>(TCondition[] conditions, TargetingRu
                     break;
 
                 case PrerequisiteFlagCondition prerequisiteFlagCondition:
-                    conditionResult = EvaluatePrerequisiteFlagCondition(prerequisiteFlagCondition, ref context, out error);
+                    conditionResult = EvaluatePrerequisiteFlagCondition(prerequisiteFlagCondition, ref context);
                     newLineBeforeThen = true;
                     break;
 
@@ -708,10 +708,8 @@ private static bool EvaluateSensitiveArrayContainsAnyOf(string[] array, string[]
         return negate;
     }
 
-    private bool EvaluatePrerequisiteFlagCondition(PrerequisiteFlagCondition condition, ref EvaluateContext context, out string? error)
+    private bool EvaluatePrerequisiteFlagCondition(PrerequisiteFlagCondition condition, ref EvaluateContext context)
     {
-        error = null;
-
         var logBuilder = context.LogBuilder;
         logBuilder?.AppendPrerequisiteFlagCondition(condition);
 
@@ -759,7 +757,7 @@ private bool EvaluatePrerequisiteFlagCondition(PrerequisiteFlagCondition conditi
         };
 
         logBuilder?
-            .NewLine().Append($"Prerequisite flag evaluation result: '{prerequisiteFlagValue ?? EvaluateLogHelper.InvalidValuePlaceholder}'.")
+            .NewLine().Append($"Prerequisite flag evaluation result: '{prerequisiteFlagValue}'.")
             .NewLine("Condition (")
                 .AppendPrerequisiteFlagCondition(condition)
                 .Append(") evaluates to ").AppendEvaluationResult(result).Append(".")