Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for wildcard (some*match) uninstalls #435

Merged
merged 5 commits into from
Feb 15, 2024
Merged

Conversation

jaimergp
Copy link
Contributor

@jaimergp jaimergp commented Feb 2, 2024

Description

Closes #434

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@jaimergp jaimergp marked this pull request as draft February 2, 2024 10:28
@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Feb 2, 2024
@jaimergp
Copy link
Contributor Author

jaimergp commented Feb 2, 2024

Test reproduces error. Pushing fix.

@jaimergp jaimergp marked this pull request as ready for review February 5, 2024 15:08
@jaimergp
Copy link
Contributor Author

jaimergp commented Feb 5, 2024

This is ready for review @jezdez, but I wonder if we should have this test added to conda/conda instead?

@jaimergp
Copy link
Contributor Author

jaimergp commented Feb 6, 2024

@zklaus - would you like trying to upstream the test added in this PR to conda/conda? 🙏

@zklaus
Copy link
Contributor

zklaus commented Feb 7, 2024

Will do ;)

@jaimergp
Copy link
Contributor Author

Passing now:

tests/cli/test_main_remove.py::test_remove_globbed_package_names[libmamba] PASSED [ 84%]

Test is included in Upstream / Integration / Group 1 (for libmamba), and Group 3 (for classic).

Ready for review!

@jaimergp jaimergp requested a review from jezdez February 15, 2024 10:55
Copy link
Member

@jezdez jezdez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any chance to add a test for the new feature?

conda_libmamba_solver/state.py Show resolved Hide resolved
@jaimergp
Copy link
Contributor Author

@jezdez The test was here initially, then Klaus upstreamed it at conda/conda#13579 because it's a conda feature, not a CLS one. That's what I meant with my earlier comment.

@jezdez jezdez merged commit 9f0da8f into main Feb 15, 2024
71 checks passed
@jezdez jezdez deleted the remove-star-pkg-name branch February 15, 2024 14:47
@zklaus zklaus removed their assignment Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed [bot] added once the contributor has signed the CLA
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

libmamba solver doesn't match when uninstalling with wildcard
4 participants