Fix frozendict usage
#5345
Fix frozendict usage
#5345
Conversation
conda-bot
added
the
cla-signed
Review build status
Once it's done, use this command to try it out in a new conda environment:
|
CodSpeed Performance ReportMerging #5345 will not alter performanceComparing Summary
|
|
@jakirkham can you review this PR/test the canary build and confirm this fixes the |
kenodegard
force-pushed
the
frozendict-bug
branch
from
6415670
to
8a74709
Compare
|
@jakirkham will you be able to review/test this? we'd like to get a patch release ready to go for next week |
| @deprecated( | ||
| "24.5.1", | ||
| "24.7.0", | ||
| addendum="Use `conda_build.metadata._check_circular_dependencies` instead.", |
There was a problem hiding this comment.
See #5345 (comment)
| @@ -907,6 +953,59 @@ def toposort(output_metadata_map): | |||
| return result | |||
|
|
|||
|
|
|||
| def _toposort_outputs(output_tuples: list[OutputTuple]) -> list[OutputTuple]: | |||
There was a problem hiding this comment.
Is this code mostly copied from elsewhere?
There was a problem hiding this comment.
Yes, this is a copy of the now deprecated toposort function in the same module, we added these new functions since the function signatures themselves changes, see #5345 (comment)
|
Thanks all! 🙏 The fix worked great 😄 |
Description
A very specific use case results in the code trying to modify a
frozendictversion of the output dict.Fix #5342
Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?Add / update outdated documentation?