-
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Debug main, do we see the same failure? #210
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Same failure here :( |
…nda-forge-pinning 2024.09.15.09.01.05
…nda-forge-pinning 2024.09.15.09.01.05
…nda-forge-pinning 2024.09.15.09.01.05
@jaimergp I think I found a bug in |
Could be virtual package handling, but could also be caching related, i.e., conda/conda-libmamba-solver#482 . |
@xhochy Nice investigation! Thanks for digging into this. |
Thanks for the report. Is it ok if I debug things in your branch directly? Thinking of creating a couple of conda-libmamba-solver branches with a couple reverts to see which one is the culprit. |
We are supposedly not using .solv files during channel reloads but maybe there's a bug in that logic too 😬 |
Yes, feel free to push freely here. |
MNT: Re-rendered with conda-build 24.7.1, conda-smithy 3.40.1, and conda-forge-pinning 2024.09.19.10.49.54
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipe/meta.yaml:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Trying conda/conda-libmamba-solver@8ed9689, no solv files at all. |
That didn't change much. Trying conda/conda-libmamba-solver@610422c, which brings conda/conda-libmamba-solver#485 back. |
Well, same story. I really wonder if this is it? conda/conda-libmamba-solver@63c545f |
No way 😂 Why! |
Let's see what the difference is with deduplicated channels or not. I suspect there's some bug in the |
The list of channels (and their URLs) are indeed identical, so I'm clueless why deduplication affects the reloading. My guess is that there might be some sort of race condition when they are reloaded rapidly in succession, so loading them twice in a row would help with the Python objects getting updated. I've added a |
Ah wait, in one of the cases we see this:
The osx-64 subdir is missing in the first channel (but not in the second), so it gets lost after deduplication. I think deduplication should be done on URLs not Channels. And this is done internally with explicit subdirs, BUT turns out that |
Published conda/conda-libmamba-solver#531 which will be released with 24.9. |
Thanks for hunting this down @jaimergp! |
Thanks for the reports! I think we can close this one, right? |
Thank you for the effort 😍 |
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)