Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add options out parameter. #397

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

romain-dartigues
Copy link

@romain-dartigues
Copy link
Author

(review requested, especially do you think it should support multiple options?)

@taylorsilva
Copy link
Member

What's the usecase you imagine for this? I mechanically understand what you're adding here, but I don't know when I would use this? Do you have an example?

@romain-dartigues
Copy link
Author

Hi Taylor,
my apologies, I haven't seen the notification.

One obvious use-case would be the one in the GitLab link, ie: --push-option=ci.skip (and/or add add variables required to trigger some parts of the pipeline through -o ci.variable="foo=bar").

In my case, one of the project hosted on a GitLab use a mix of Concourse pipelines and GitLab CI pipelines; being able to disable or trigger the GitLab pipeline trough the git-resource of Concourse would be useful.

Copy link
Member

@taylorsilva taylorsilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay, lots of stuff to look at across all the repos!

Noticing we have no test here for this and we should add one I think: https://github.com/concourse/git-resource/blob/master/test/put.sh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants