Issue #8943: Check log retention max days & max builds is set globally #8944
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
build_log_retention.days
is being ignored and defaulting to0
ifCONCOURSE_MAX_BUILD_LOGS_TO_RETAIN
is set butCONCOURSE_MAX_DAYS_TO_RETAIN_BUILD_LOGS
is not.The same applies the other way round,
build_log_retention.builds
is ignored and defaults to0
ifCONCOURSE_MAX_DAYS_TO_RETAIN_BUILD_LOGS
is set butCONCOURSE_MAX_BUILD_LOGS_TO_RETAIN
is not.Steps to reproduce
CONCOURSE_MAX_BUILD_LOGS_TO_RETAIN: 5
indocker-compose.yml
build_log_retention.builds
to 3 and setbuild_log_retention.days
to 7 (see example below).atc.reaper.tick.build-reaper.start
logExpected results
Logs should not be reaped until 7 days later.
Actual results
Logs are reaped at 0 days!
Additional context
Example pipeline for testing...
Triaging info
v7.9.1