fix: Change the "userIDFieldPerConnector" parameter's place #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change the parameter "userIDFieldPerConnector" to the correct place (it's the one currently working at least), which is "concourse.web.auth.userIDFieldPerConnector" instead of "concourse.web.auth.mainTeam.userIDFieldPerConnector". - Add the parameter "concourse.web.auth.userIDFieldPerConnector" to the table.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why do we need this PR?
The
concourse-chart/templates/web-deployment.yamlfile is looking forValues.concourse.web.auth.userIDFieldPerConnectorbut the parameter is inconcourse.web.auth.mainTeam.userIDFieldPerConnector, according to the documentation.Changes proposed in this pull request
userIDFieldPerConnectorto the correct place, which isconcourse.web.auth.userIDFieldPerConnectorinstead ofconcourse.web.auth.mainTeam.userIDFieldPerConnector(or the opposite, if that's what is decided. But in that case it shouldn't go to themasterbranch).Contributor Checklist
README.mdmasteris for changes related to the current release of theconcourse/concourse:latestimage and should be good to publish immediatelydevis for changes related to the next release of Concourse (aka unpublished code onmasterin concourse/concourse)Reviewer Checklist
masterordev)