Use user and channel of recipe if not specified #603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@pgrohs Thank you for your contribution. Please, check those failed test. It seems like your feature broke some of them. Probably you need to validate case where user and channel are used, but they are None. |
|
@uilianries I have updated the PR. Could please run the test cases? |
|
@pgrohs Sorry the delay. Starting it now |
|
@uilianries Could you please try to run the CI pipeline again? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: (Feature): Capture username and channel from conanfile.py
Closes #602
In case user or channel are not given to ConanMultiPackager via parameter or environment variable, both are taken from the recipe to build. The overcomes the necessity to repeat user and channel of the recipe in the build script. Furthermore, it enables the realization of custom channel-strategies in the recipe.