-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: create redirects for logo files #235
base: main
Are you sure you want to change the base?
Conversation
logo-dark goes to the logo with dark text logo-light goes to the logo with light text
✅ Deploy Preview for compilerla ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I grabbed both logo files from Google Drive (Compiler Branding Identity
> Brand Kit
> Logo
> Logo Stacked
> PNG
)
The files Compiler Logo_Stacked_WhiteTeal.png
and Compiler Logo_Stacked_WhiteGreen.png
for some reason don't actually use the teal or green color.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Open question on if this logo is ok for the light version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AnthonyRollins and I have been looking at this PR and talking about it a bit here.
@angela-tran what do you think about, instead of having each of these logos with their own redirect, we create a single page called /brand
with a table of each logo option? We can eventually use this as an external "brand kit" type page, and for now it will serve the use case of #168.
This is similar to the idea in #49 too, but more for an external audience whereas the style guide is more an internal/website team audience.
I like this idea. A single page that fulfills multiple use cases sounds better to me! |
Closes #168
/logo-dark
goes to the logo with dark text/logo-light
goes to the logo with light text