Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: create redirects for logo files #235

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

angela-tran
Copy link
Member

@angela-tran angela-tran commented Jul 26, 2024

Closes #168

/logo-dark goes to the logo with dark text
/logo-light goes to the logo with light text

logo-dark goes to the logo with dark text
logo-light goes to the logo with light text
@angela-tran angela-tran self-assigned this Jul 26, 2024
Copy link

netlify bot commented Jul 26, 2024

Deploy Preview for compilerla ready!

Name Link
🔨 Latest commit 40e151a
🔍 Latest deploy log https://app.netlify.com/sites/compilerla/deploys/66a3e67274fd24000848ce08
😎 Deploy Preview https://deploy-preview-235--compilerla.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I grabbed both logo files from Google Drive (Compiler Branding Identity > Brand Kit > Logo > Logo Stacked > PNG)

The files Compiler Logo_Stacked_WhiteTeal.png and Compiler Logo_Stacked_WhiteGreen.png for some reason don't actually use the teal or green color.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like I edited the SVG myself to get teal into the white SVG currently used on the site

image

source

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Open question on if this logo is ok for the light version

@angela-tran angela-tran marked this pull request as ready for review July 26, 2024 18:25
@angela-tran angela-tran requested a review from a team as a code owner July 26, 2024 18:25
Copy link
Member

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AnthonyRollins and I have been looking at this PR and talking about it a bit here.

@angela-tran what do you think about, instead of having each of these logos with their own redirect, we create a single page called /brand with a table of each logo option? We can eventually use this as an external "brand kit" type page, and for now it will serve the use case of #168.

This is similar to the idea in #49 too, but more for an external audience whereas the style guide is more an internal/website team audience.

@angela-tran
Copy link
Member Author

@angela-tran what do you think about, instead of having each of these logos with their own redirect, we create a single page called /brand with a table of each logo option? We can eventually use this as an external "brand kit" type page, and for now it will serve the use case of #168.

This is similar to the idea in #49 too, but more for an external audience whereas the style guide is more an internal/website team audience.

I like this idea. A single page that fulfills multiple use cases sounds better to me!

@angela-tran angela-tran marked this pull request as draft July 26, 2024 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

request for quicklink for logo files
2 participants