Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed several scripts placed at wrong category #1661

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

tremor021
Copy link

@tremor021 tremor021 commented Jan 22, 2025

✍️ Description



✅ Prerequisites

The following steps must be completed for the pull request to be considered:

  • [*] Self-review performed (I have reviewed my code to ensure it follows established patterns and conventions.)
  • [*] Testing performed (I have thoroughly tested my changes and verified expected functionality.)

🛠️ Type of Change

Please check the relevant options:

  • [*] Bug fix (non-breaking change that resolves an issue)
  • [] New feature (non-breaking change that adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to change unexpectedly)
  • [] New script (a fully functional and thoroughly tested script or set of scripts)

📋 Additional Information (optional)

image
As you can see, several misplaced scripts

@tremor021 tremor021 requested a review from a team as a code owner January 22, 2025 00:47
@github-actions github-actions bot added the website A change to the website label Jan 22, 2025
@tremor021
Copy link
Author

Checking the Proxmox and Virtualization category revealed several scripts getting their category id wrong

Copy link
Author

@tremor021 tremor021 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MickLesk
Copy link
Member

ThThey are all in there because they are not LXCs or similar, but support working with Proxmox. If so, a 2nd category would make more sense, but this is not possible with the current frontend.

@tremor021
Copy link
Author

Ah, so it's intended to be this way. Just decline the PR until frontend allows more categories

@MickLesk
Copy link
Member

so now you can add an second category, can you rework your PR? (code-studio already done)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
website A change to the website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants