Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there !
This is my first pull-request here, I hope I won't be too damned :)
I am trying to enter and understand the voice-web architecture and stack so I've decided to tackle an ongoing issue.
I know there are many ways to add dark-mode to a website but I found this gem: https://github.com/donavon/use-dark-mode (custom React hook). Let me know what are your thoughts.
The src files were quite hard to go through at first but I managed to understand the Layout component. I have added a small toggle at the left side, modified .css files to stay constant with the colors (needs review and input) and used a html color opposite generator for hexa numbers.
In the midst of my struggle I have added the --profiler option to the yarn build command in the docker settings file to have access to the react dev tool extension, which is sweet for devs: https://addons.mozilla.org/en-US/firefox/addon/react-devtools/
Disclamer: this is a work in progress but that would need eyes on as I think developing this feature could be a great asset to the ppl having vision accessibility issues or just for someone that is hurt from the white light but still want to contribute.
I would especially need help for the color management and .css file all throughout the project as I have probably missed some.
This is linked to issue: github.com/mozilla/voice-web/issues/2533
Thank you so much in advance for your input. I'm here to please the PR requirements and hopefully make this dark-mode work perfectly.