Improve workflow and fix ESM modules #3
+3,872
−1,050
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@endel Had issue with your ESM code
you can try it with a simple with bun (ou deno or node as u which), the important part is
"type": "module"
or use a.mjs
file., so i rewrote full clock and timer (as they depends on each others.)
They both works in commonJS and ESM.
Based on work from https://www.totaltypescript.com/how-to-create-an-npm-package for best practice and ensure export are stable.