Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Implement support for "Blackmagic Design" camera colour encodings. #793

Draft
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

nick-shaw
Copy link
Contributor

Add basic support for Blackmagic camera colour encodings.

@KelSolaar KelSolaar changed the title Feature/blackmagic PR: Implement support for "Blackmagic Design" camera colour encodings. Mar 14, 2021
@KelSolaar
Copy link
Member

KelSolaar commented Jun 26, 2021

Moving some of the discussion here so that they don't disappear in Slack's Void.

So we have three notebooks doing curve fitting:

This one is the original Nick built with semi-manual break-point and fitting, it assumes a quasi-log function, i.e. colour.models.logarithmic_function_quasilog definition and a linear function.

Based on Nick's notebook and implementing fully automatic fitting, it also assumes a quasi-log function, i.e. colour.models.logarithmic_function_quasilog definition and a linear function.

Based on Nick's notebook and implementing fully automatic fitting, it however assumes the piece-wise CLF camera log function, i.e. colour.models.logarithmic_function_camera.

I would be keen to have a single notebook we can refer to but besides that, we should decide on how we want to implement the functions in Colour. I was hoping that we could use colour.models.logarithmic_function_camera definition, but the last two LUTs, i.e. BMD_POCKET_4K_FILM_LUT and BMD_POCKET_6K_FILM_LUT, have a joining problem which is evident in my notebook when using colour.models.logarithmic_function_camera:

image

It can be corrected with a blending function but at this point, we might as well use colour.models.logarithmic_function_quasilog definition and a linear segment:

image

Thoughts?

@KelSolaar KelSolaar requested a review from KevinJW June 26, 2021 23:04
@KelSolaar KelSolaar marked this pull request as draft July 23, 2023 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants