Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Plone 5 related upgrade steps in Plone 6. #432

Merged
merged 2 commits into from
Oct 8, 2024
Merged

Fix Plone 5 related upgrade steps in Plone 6. #432

merged 2 commits into from
Oct 8, 2024

Conversation

thet
Copy link
Member

@thet thet commented Oct 8, 2024

When upgrading from Plone 5 to Plone 6, the upgrade broke with:

2024-10-08 13:18:11,350 INFO    [ftw.upgrade:177][waitress-0] ______________________________________________________________________
2024-10-08 13:18:11,351 INFO    [ftw.upgrade:178][waitress-0] UPGRADE STEP collective.easyform:default: Update last_compilation of bundle
2024-10-08 13:18:11,351 ERROR   [ftw.upgrade:39][waitress-0] FAILED

We're not using the last_compilation registry entry anymore, thankfully.

This PR fixes that by just ignoring the last_compilation update method in Plone 6.

ale-rt
ale-rt approved these changes Oct 8, 2024
View reviewed changes
Copy link
Member

@ale-rt ale-rt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thet thet merged commit 18000cd into master Oct 8, 2024
4 checks passed
@thet thet deleted the fix-plone6-upgrade branch October 8, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ale-rt ale-rt ale-rt approved these changes

@cillianderoiste cillianderoiste Awaiting requested review from cillianderoiste

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thet @ale-rt