Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backport fix to 3.x branch #413

Merged
merged 1 commit into from
Dec 10, 2024
Merged

backport fix to 3.x branch #413

merged 1 commit into from
Dec 10, 2024

Conversation

Nimo-19
Copy link
Contributor

@Nimo-19 Nimo-19 commented Sep 6, 2023

Solves #386 by backporting the fix from 3fa337b to the 3.x branch

mauritsvanrees
mauritsvanrees approved these changes Dec 10, 2024
View reviewed changes
Copy link
Member

@mauritsvanrees mauritsvanrees left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

The Python 2.7 job is failing, but that is because Python 2.7 is not found. Preferably we would fix that, but that has nothing to do with this PR.

@mauritsvanrees mauritsvanrees merged commit 927db66 into collective:3.x Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mauritsvanrees mauritsvanrees mauritsvanrees approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nimo-19 @mauritsvanrees